search

tiddlyhost / tiddlyhost-com

Rails application for creating and hosting TiddlyWiki sites, plus resources for deploying it to https://tiddlyhost.com/
Other
188 stars 18 forks source link

Don't respond with `406 Not Acceptable` to TiddlyWiki HEAD requests with accept header "*/*;charset=UTF-8" #343

Closed simonbaird closed 3 months ago

simonbaird commented 3 months ago

IIUC */*;charset=UTF-8 is not considered a valid accept header by rails, but this is what TiddlyWiki 5 uses when making a HEAD request to determine the etag value.

It should be possible to make rails treat that header as valid and respond with a valid head response.

(It's not clear if this problem is causing the performance problems from #342, but it's possible that it is contributing, so let's try fixing it.)

simonbaird commented 3 months ago

Should be fixed now.

The impact of this bug is related to the way Tiddlyhost and TiddlyWiki makes use uses the "ETag" to help avoid overwriting changes made in another browser tab, or another device, which I think has been broken for some time.

So I'm glad it's fixed, but it probably doesn't impact performance.

simonbaird commented 3 months ago

(The commit that fixes this is in a branch local to my laptop, will push it up soon.)