In Messages, can't tell which patient a comment is for in "all messages" list

HowardLook commented 10 years ago

I am on Brandon's care team and Katie's care team. Brandon is also on Katie's care team. In this view, I can't tell which person Brandon's messages are meant for. I think we need to indicate the PwD's name (the person whose data was being commented upon). As is, it wont work for doctors. Making P1 for Pilot. @jh-bate please let @skrugman if you need any design help for this.

cheddar commented 10 years ago

PwD's new meaning! Person with data!

jebeck commented 10 years ago

+1 @cheddar

jh-bate commented 10 years ago

yeah I think this is just a "my bad" and sara had already specified that detail. Just work on it now

On Wed, Apr 30, 2014 at 12:21 PM, Jana Beck notifications@github.comwrote:

+1 @cheddar https://github.com/cheddar

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/44#issuecomment-41748021 .

jh-bate commented 10 years ago

I have an initial fix that I will deploy to devel

jh-bate commented 10 years ago

@HowardLook @brandonarbiter - An initial fix is deployed to https://devel-clamshell.tidepool.io/. If your happy I will push it t staging.

HowardLook commented 10 years ago

+1 for "person with data. " I will totally use that!

Howard Look President and CEO, Tidepool howard@tidepool.org C: 650-823-0021

Tidepool is an open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

On Apr 29, 2014, at 5:21 PM, Jana Beck notifications@github.com wrote:

+1 @cheddar

— Reply to this email directly or view it on GitHub.

brandonarbiter commented 10 years ago

Leaving gym, grabbing dinner. Will check it out at home.

Sent from my iPhone

On Apr 29, 2014, at 8:31 PM, Howard Look notifications@github.com wrote:

+1 for "person with data. " I will totally use that!

Howard Look President and CEO, Tidepool howard@tidepool.org C: 650-823-0021

Tidepool is an open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

On Apr 29, 2014, at 5:21 PM, Jana Beck notifications@github.com wrote:

+1 @cheddar

— Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.

HowardLook commented 10 years ago

Testing on devel. Definitely better, but still not 100%. Below messages to Katie show with Katie's name, but not the message I sent to Brandon (on the Tandem pump).

HowardLook commented 10 years ago

Also, I think we need to show first and last names, since the doctors may have many patients with the same first name.

jh-bate commented 10 years ago

First and last name of just the person w data? i.e. Jamie > Howard Look On Apr 30, 2014 4:55 PM, "Howard Look" notifications@github.com wrote:

Also, I think we need to show first and last names, since the doctors may have many patients with the same first name.

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/44#issuecomment-41760743 .

HowardLook commented 10 years ago

I think it has to be first and last for both, otherwise it won't make sense to the doctors. (e.g. what if one of the people commenting has the same first name as a doctor? How will they know?

H

On Tue, Apr 29, 2014 at 10:06 PM, Jamie notifications@github.com wrote:

First and last name of just the person w data? i.e. Jamie > Howard Look On Apr 30, 2014 4:55 PM, "Howard Look" notifications@github.com wrote:

Also, I think we need to show first and last names, since the doctors may have many patients with the same first name.

— Reply to this email directly or view it on GitHub< https://github.com/tidepool-org/hub/issues/44#issuecomment-41760743> .

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/44#issuecomment-41761201 .

Howard Look President and CEO, Tidepool howard@tidepool.org C: 650-823-0021

Tidepool is an open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

skrugman commented 10 years ago

@jamie you could move the profile image down to fit the full names in.

On Wed, Apr 30, 2014 at 7:09 AM, Howard Look notifications@github.comwrote:

I think it has to be first and last for both, otherwise it won't make sense to the doctors. (e.g. what if one of the people commenting has the same first name as a doctor? How will they know?

H

On Tue, Apr 29, 2014 at 10:06 PM, Jamie notifications@github.com wrote:

First and last name of just the person w data? i.e. Jamie > Howard Look On Apr 30, 2014 4:55 PM, "Howard Look" notifications@github.com wrote:

Also, I think we need to show first and last names, since the doctors may have many patients with the same first name.

— Reply to this email directly or view it on GitHub< https://github.com/tidepool-org/hub/issues/44#issuecomment-41760743> .

— Reply to this email directly or view it on GitHub< https://github.com/tidepool-org/hub/issues/44#issuecomment-41761201> .

Howard Look President and CEO, Tidepool howard@tidepool.org C: 650-823-0021

Tidepool is an open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

—

Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/44#issuecomment-41761342 .

jh-bate commented 10 years ago

Thanks Sara, yeah I can have a play with that, that's my only real concern is running out of space. On Apr 30, 2014 9:26 PM, "skrugman" notifications@github.com wrote:

@jamie you could move the profile image down to fit the full names in.

On Wed, Apr 30, 2014 at 7:09 AM, Howard Look notifications@github.comwrote:

I think it has to be first and last for both, otherwise it won't make sense to the doctors. (e.g. what if one of the people commenting has the same first name as a doctor? How will they know?

H

On Tue, Apr 29, 2014 at 10:06 PM, Jamie notifications@github.com wrote:

First and last name of just the person w data? i.e. Jamie > Howard Look On Apr 30, 2014 4:55 PM, "Howard Look" notifications@github.com wrote:

Also, I think we need to show first and last names, since the doctors may have many patients with the same first name.

— Reply to this email directly or view it on GitHub< https://github.com/tidepool-org/hub/issues/44#issuecomment-41760743> .

— Reply to this email directly or view it on GitHub< https://github.com/tidepool-org/hub/issues/44#issuecomment-41761201> .

Howard Look President and CEO, Tidepool howard@tidepool.org C: 650-823-0021

Tidepool is an open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

—

Reply to this email directly or view it on GitHub< https://github.com/tidepool-org/hub/issues/44#issuecomment-41761342> .

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/44#issuecomment-41777008 .

nicolashery commented 10 years ago

I'm going to use the following "page" names:

"All Notes" -> the home page, with all the notes
"PWD Notes" -> all notes for a particular person with data
"Note Thread" -> the note and its comments for a particular thread

@jh-bate was able to make the change for the "All Notes" and "PWD Notes" pages:

"Howard Look > Jamie Bate" when messaging to other
"Howard Look" when messaging to self

I've also made a few tweaks:

If name is too long for navbar, show "..." so navbar stays the same height and doesn't cover up the message below
On the "Note Thread" page, also use full names for messages and change the navbar title from "Jamie's notes" to "Jamie Bate" (same as "PWD Notes" page) for clarity and consistency

In pictures:

"ALL NOTES" NOW: screen shot 2014-04-30 at 3 27 44 pm

NAVBAR BEFORE: screen shot 2014-04-30 at 3 07 24 pm

NAVBAR AFTER: screen shot 2014-04-30 at 3 06 58 pm

"NOTE THREAD" BEFORE: screen shot 2014-04-30 at 3 12 17 pm

"NOTE THREAD" AFTER: screen shot 2014-04-30 at 3 20 29 pm

jh-bate commented 10 years ago

Merged to master and tagged as v0.1.10 for clamshell

jh-bate commented 10 years ago

@HowardLook so this change has been made and deployed to prod- are we happy and can we now close this issue?

HowardLook commented 10 years ago

Yes, love it. Thanks!

Howard Look President and CEO, Tidepool howard@tidepool.org C: 650-823-0021

Tidepool is an open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

On May 4, 2014, at 2:16 PM, Jamie notifications@github.com wrote:

@HowardLook so this change has been made and deployed to prod- are we happy and can we now close this issue?

— Reply to this email directly or view it on GitHub.

tidepool-org / hub

In Messages, can't tell which patient a comment is for in "all messages" list #44