"Go" / "Log in" / and "Done" for signing into the notes app is redundant

[skrugman]

"Go" in the keyboard doesn't do anything. "Done" minimizes the keyboard. and Log in is what we actually want - to log in.

Can we get rid of the "Done" and make the "go" a "Done" that minimizes the keyboard?

[skrugman]

In communication with Nico about it. There must be a way...

On Mon, May 5, 2014 at 6:18 PM, Kent Quirk notifications@github.com wrote:

Reopened #78 https://github.com/tidepool-org/hub/issues/78.

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/78#event-117893998 .

[nicolashery]

Hum, yeah I'm afraid Kent is right. But that is the keyboard iOS shows when there is a form with submit.

It's not that bad actually, what I'm going to fix is that when you hit "Go" (equivalent to hitting "Enter" on the desktop), it actually logs you in.

[kentquirk]

Sorry, I was a bit fumble-fingered there. Because we're not building a native app yet, we have limited control over the behavior of the iOS-standard things. But I'm glad to hear we can at least trap the Go button.

[skrugman]

What about the "done" - thats not a standard is it?

On Mon, May 5, 2014 at 6:55 PM, Nicolas Hery notifications@github.comwrote:

Hum, yeah I'm afraid Kent is right. But that is the keyboard iOS shows when there is a form with submit.

It's not that bad actually, what I'm going to fix is that when you hit "Go" (equivalent to hitting "Enter" on the desktop), it actually logs you in.

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/78#issuecomment-42209847 .

[nicolashery]

I think it is @skrugman, sorry. I'll see when I get to fixing the "Go" button if there is anything we can do...

[cmakler]

https://trello.com/c/zDaWFine

[jh-bate]

@nicolashery with PR https://github.com/tidepool-org/clamshell/pull/25 I changed the Login to be an actual button which might go part way to resolving this issue