tidepool-org / hub

[DEPRECATED] Central storage for Tidepool planning and issue tracking.
2 stars 2 forks source link

Can't see two basal patterns in settings at same time #95

Open HowardLook opened 10 years ago

HowardLook commented 10 years ago

With @jebeck and @cheddar looking at this: We want to compare "Pattern 1" and "Pattern 3" at the same time, but when you open one, the other closes. We should be able to open them both at the same time. Propose we switch to the "norgie" twist open disclosure triangle and allow one or more to be open at the same time.

I propose this should be fixed during pilot, opening bid at P3.

@skrugman fyi, thoughts?

kentquirk commented 10 years ago

I asked Jana about this a while back and the reason we didn't do it that way is that it would require that the settings page grow a scroll bar, which would complicate a bunch of things because we've avoided the system scroll bar in favor of our own. I propose this feature be saved for a future rework of settings to a longer-term design.

jebeck commented 10 years ago

Couldn't have said it better myself @kentquirk. If we want a scrolling model for the design, I think this issue will be dependent on https://github.com/tidepool-org/tideline/issues/27 because otherwise users will have an inconsistent experience between our scroll bar and the browser native scrolling on the settings page, and that, I believe, will cause confusion.

skrugman commented 10 years ago

We should be able to open both basal patterns at once (with the open and close norgies) - to allow comparison. How should we fix the scroll bar inconsistency @jebeck ?

On Fri, May 9, 2014 at 9:38 PM, Jana Beck notifications@github.com wrote:

Couldn't have said it better myself @kentquirkhttps://github.com/kentquirk. If we want a scrolling model for the design, I think this issue will be dependent on tidepool-org/tideline#27https://github.com/tidepool-org/tideline/issues/27because otherwise users will have an inconsistent experience between our scroll bar and the browser native scrolling on the settings page, and that, I believe, will cause confusion.

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/95#issuecomment-42705287 .

Sara Krugman Lead Interaction Designer

Tidepool An open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

Phone : +45 42 74 68 17 Email : sara@tidepool.org Web : Tidepool.org http://tidepool.org/

jebeck commented 10 years ago

@skrugman as I said, I think it would be best to wait until we can deliver a consistent experience. If we want to deliver an inconsistent experience, it will be a small change in the logic behind the click behaviors and the CSS. If that's the route we want to go, just LMK.

skrugman commented 10 years ago

@HowardLook what do you think? I say we keep it as a P3 but @jebeck what will it be? Two native scroll bars or two blip scroll bars?

HowardLook commented 10 years ago

We should discuss in the context of all other priorities when we do a backlog scrub.

H

On Mon, May 12, 2014 at 10:35 AM, skrugman notifications@github.com wrote:

@HowardLook https://github.com/HowardLook what do you think? I say we keep it as a P3 but @jebeck https://github.com/jebeck what will it be? Two native scroll bars or two blip scroll bars?

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/95#issuecomment-42862823 .

Howard Look President, CEO and Founder

Tidepool An open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

Phone : 650-823-0021 Email : howard@tidepool.org Web : Tidepool.org http://tidepool.org/

jebeck commented 10 years ago

The way I was envisioning it, @skrugman, it will still be one native scrollbar and one manual SVG scrollbar, but they will behave the same in terms of responding to scroll wheel/trackpad events, so the user won't be able to tell much difference.

skrugman commented 10 years ago

Okay. Seems okay.

jebeck commented 10 years ago

Actually, it occurred to me now that there may be some people who have very very complex basal schedules that will overrun the display if we don't introduce scrolling at the beginning. @skrugman maybe we can test on your new one - I think you said it changes every hour? We may have to sacrifice consistency here. (Or layout the basal schedules horizontally instead.)

skrugman commented 10 years ago

Just uploaded with the new settings (many). I don't get the problem of scrolling fully... When the screen becomes too long for the browser the native scrollbar shows up and it works just fine. Is it that - if the patterns are all open at once, then they will get hidden under the bottom bar of the blip frame? Maybe we should talk about this live to make sure I understand correctly.

On Tue, May 13, 2014 at 6:50 PM, Jana Beck notifications@github.com wrote:

Actually, it occurred to me now that there may be some people who have very very complex basal schedules that will overrun the display if we don't introduce scrolling at the beginning. @skrugmanhttps://github.com/skrugmanmaybe we can test on your new one - I think you said it changes every hour? We may have to sacrifice consistency here. (Or layout the basal schedules horizontally instead.)

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/hub/issues/95#issuecomment-42981097 .

Sara Krugman Lead Interaction Designer

Tidepool An open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

Phone : +45 42 74 68 17 Email : sara@tidepool.org Web : Tidepool.org http://tidepool.org/

jebeck commented 10 years ago

Hmm, we must have set the overflow to auto somewhere I guess. The experience should be the same as what you're seeing with a long pattern if we allow expanding all. If that's what you want, @ianjorgensen should be able to adjust the behavior since he's working on the twisty triangle now.