tidepool-org / tideline

Library for Tidepool's timeline-style diabetes data visualization(s) used in Blip
BSD 2-Clause "Simplified" License
38 stars 16 forks source link

Data is one day view should indicate Pattern in effect #112

Open brandonarbiter opened 10 years ago

brandonarbiter commented 10 years ago

Patterns are displayed in device settings, but not referred to in the one day view. Blip should indicate within the one day view which pattern is in effect.

Cc: @HowardLook

jebeck commented 10 years ago

I think we have the data for this, at least for Carelink. @cheddar confirm?

We also aren't telling you what your active schedule is when you look at your most recent settings (i.e., the settings page), and we have the data for that, I believe.

jebeck commented 10 years ago

Oh, not sure we have a design for indicating your currently active schedule on the settings page though. @skrugman?

cheddar commented 10 years ago

Yes, you are currently being delivered a timeline of all settings objects. Each one is generated because it is somehow different than the others. So you should already have everything you need to deal with this.

kentquirk commented 10 years ago

But we do need a design for displaying it and it needs to account for showing when it changes -- and it could potentially change multiple times in a day. So this should probably start with a design task.

On Wed, May 7, 2014 at 12:38 PM, cheddar notifications@github.com wrote:

Yes, you are currently being delivered a timeline of all settings objects. Each one is generated because it is somehow different than the others. So you should already have everything you need to deal with this.

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/tideline/issues/112#issuecomment-42450956 .

Kent Quirk VP of Engineering, Tidepool

Tidepool is an open source, not-for-profit effort to build an open data platform and better applications to reduce the burden of Type 1 Diabetes.

jebeck commented 10 years ago

This will be solved in part or in full by https://github.com/tidepool-org/hub/issues/96

skrugman commented 10 years ago

Design for where to say what pattern is being shown if it is one pattern or two patterns in the same screen. Only show the A | B in the actual basal when there is a change, otherwise we show which pattern is displayed next to the title. Specs are in design criteria and screen shot of them here too.

screen shot 2014-05-14 at 1 37 48 pm screen shot 2014-05-13 at 2 08 00 pm screen shot 2014-05-14 at 1 44 26 pm

kentquirk commented 10 years ago

For what it's worth, to my eyes that A | B is essentially invisible. I have a big, properly adjusted Apple monitor and good vision for my age, but I really think there needs to be more contrast.

skrugman commented 10 years ago

Okay, take away the 50% opacity from the spec (ill update design criteria). It is secondary info though, detail info....many requests we have from users are to add something. My mission is to keep this interface simple. The opacity pushes it back.

cheddar commented 10 years ago

Could it be part of the tooltip on hover?

Or, what about another timeline with points where the settings have changed? One of those settings is the "active" schedule.

jebeck commented 10 years ago

This will also be addressed in https://github.com/tidepool-org/hub/issues/96, can we table the design discussion a bit for now until 96 is done? We've prioritized it as the next highest thing to work on, since it's a request from Saleh partly as a compromise given the Diasend basals situation.

skrugman commented 10 years ago

Yep!

On Wed, May 14, 2014 at 6:19 PM, Jana Beck notifications@github.com wrote:

This will also be addressed in tidepool-org/hub#96https://github.com/tidepool-org/hub/issues/96, can we table the design discussion a bit for now until 96 is done? We've prioritized it as the next highest thing to work on, since it's a request from Saleh partly as a compromise given the Diasend basals situation.

— Reply to this email directly or view it on GitHubhttps://github.com/tidepool-org/tideline/issues/112#issuecomment-43102543 .

Sara Krugman Lead Interaction Designer

Tidepool An open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.

Phone : +45 42 74 68 17 Email : sara@tidepool.org Web : Tidepool.org http://tidepool.org/