search

tidepool-org / tools

A place to put tooling and scripts that help when working on Tidepool stuff.
Other
11 stars 11 forks source link

[UPLOAD-1068] Add ability to build docker images on CircleCI #101

Closed krystophv closed 3 months ago

krystophv commented 1 year ago

To support UPLOAD-1068, needed to be able to build docker images on CircleCI (since Uploader needs access to a private submodule and TravisCI only lets you have entirely private or entirely public, not public accessing some private resources).

darinkrauss commented 1 year ago

@krystophv Can we update this PR so a Docker image from a PR build is tagged with the PR number instead of the feature branch name? So, instead of something like BACK-1234-some-feature-8d5c71e3665fabd1f19241901c059bd36e0532c3-1699656709 it is PR-123-8d5c71e3665fabd1f19241901c059bd36e0532c3-1699656709 or similar format? Something to make it easy to see if is from a PR and different than the feature branch?

gniezen commented 3 months ago

@krystophv Can we merge this now that https://tidepool.atlassian.net/browse/UPLOAD-1068 is ready for deployment?

krystophv commented 3 months ago

@gniezen I believe so, yeah. I'll hit the button.