tidepool-org / tools

A place to put tooling and scripts that help when working on Tidepool stuff.
Other
11 stars 11 forks source link

Update get_current_tidepool_repos.sh to use bash #23

Closed davidmdem closed 9 years ago

davidmdem commented 9 years ago

/bin/sh is typically implemented as a symbolic to the bash shell. Recent releases of Ubuntu change this implementation to point to another shell called dash (reference). This causes the script to fail on line 31 with the error Syntax error: "(" unexpected.

Changing the shell reference to /bin/bash allows the script to run.

kentquirk commented 9 years ago

Thank you! As this is a minimal (2-character) change, I'm going to simply accept it. For larger changes, we'd have to get you to sign our contributor's agreement first. If you're in the mood, please feel free to sign it here by following the instructions on that page.

davidmdem commented 9 years ago

Thank you and sorry about missing the contribution guidelines. I have squared that away following the guidelines linked (long form, emailed to legal@tidepool.org).