search

tidepool-org / tools

A place to put tooling and scripts that help when working on Tidepool stuff.
Other
11 stars 11 forks source link

Environment variables missing when running docker-compose #68

Closed franck-fourel closed 6 years ago

franck-fourel commented 6 years ago

I cannot run the full tidepool stack with the docker-compose since I updated all my images with docker-compose pull. Below is the list of containers that fail during start-up command

docker-compose up -d

dockerstatus

I noticed that the Dockerfiles of the failing images have been modified recently. For example the hakken dockerfile does not contain anymore the environment variables: https://github.com/tidepool-org/hakken/commit/f491a2983e0b27784f96ac63e0dd99f488ee1b23

Below is the log for this hakken service:

Attaching to hakken
hakken            | /app/node_modules/amoeba/lib/config.js:22
hakken            |       throw except.ISE('Must specify environment variable[%s]', name);
hakken            |       ^
hakken            |
hakken            | Error: Must specify environment variable[ANNOUNCE_HOST]
hakken            |     at Object.ISE (/app/node_modules/amoeba/lib/except.js:24:18)
hakken            |     at Object.exports.fromEnvironment (/app/node_modules/amoeba/lib/config.js:22:20)

I'm wondering if I missed something or if my docker images were not up to date but all of the failing services have the same kind of error related to missing environment variables.

I also noticed the variables are still available in https://github.com/tidepool-org/tools/blob/master/runservers#L136
Would that be a regression only in docker-compose or something that I missed in documentation?

clintonium-119 commented 6 years ago

Ahh. Our apologies.

We've recently launched a new docker development stack, and haven't yet pulled the legacy code and instructions out of this repo.

The new stack can be found here

Thanks for reporting this. I'll get a PR in to clean things up in this repo.

franck-fourel commented 6 years ago

Thanks a lot. I will test it right now and I will tell you if I have any issue.

Le mar. 6 mars 2018 à 15:27, Clint Beacock notifications@github.com a écrit :

Ahh. Our apologies.

We've recently launched a new docker development stack, and haven't yet pulled the legacy code and instructions out of this repo.

The new stack can be found here https://github.com/tidepool-org/development

Thanks for reporting this. I'll get a PR in to clean things up in this repo.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidepool-org/tools/issues/68#issuecomment-370798213, or mute the thread https://github.com/notifications/unsubscribe-auth/AVQwVj_ZV78z_RNRhIjcNmLONqHJq3xSks5tbpzdgaJpZM4SekJc .

clintonium-119 commented 6 years ago

Closed by #69