Penultimate step in ci changes: remove redundant files.

tidepool-org / tools

A place to put tooling and scripts that help when working on Tidepool stuff.

Other

11 stars 11 forks source link

Penultimate step in ci changes: remove redundant files. #77

Closed derrickburns closed 4 years ago

derrickburns commented 5 years ago

All the service repos that produce Docker artifacts have been updated to provide an argument to artifact.sh indicating which type of artifact to produce. All make reference to artifact.sh. This eliminates all need for the redundant files.

Additionally, we now distinguish a PR image from a non-PR image in the Docker image tag.

Removes redundant files.
Removes decoding of the file name.
Pass argument for proper artifact creation.
Prefixes PR image tags with "PR-"

derrickburns commented 5 years ago

@pazaan

I added a check to see if the trigger was a PR so that we may label the images distinctly. I also corrected a bug.

Unfortunately, we need to merge it to test it. :)

derrickburns commented 5 years ago

This cannot be merged into master until ALL repos that use artifact.sh refer to the correct file name.

pazaan commented 5 years ago

@derrickburns Has this PR gone stale? Should it be updated and re-reviewed? Or just closed out?