tidepool-org / uploader

An Electron app for uploading diabetes device data to Tidepool's backend
BSD 2-Clause "Simplified" License
119 stars 86 forks source link

Fixes for time update messaging (UPLOAD-1201, UPLOAD-1157) #1621

Closed gniezen closed 5 months ago

gniezen commented 7 months ago

Addresses UPLOAD-1201 and UPLOAD-1157.

gniezen commented 7 months ago

@krystophv I decided to add UPLOAD-1157 to this PR, as they're both related to the update-time modal.

vojtech-cerveny commented 5 months ago

@gniezen, build-macos check fails and it is required to merge. Can you check it what's wrong please?

It seems that github already have this asset, if I get it right.

From log:

Failed Task: build
Stack Trace: HttpError: 422 Unprocessable Entity

Method: POST
URL: https://uploads.github.com/repos/tidepool-org/uploader/releases/150421733/assets?name=Tidepool%20Uploader-2.57.0-time-message-fix.2-mac.zip.blockmap

Data:
{
  "message": "Validation Failed",
  "request_id": "C1A7:368889:27CDF3:2C0534:66686CB9",
  "documentation_url": "https://docs.github.com/rest",
  "errors": [
    {
      "resource": "ReleaseAsset",
      "code": "already_exists",
      "field": "name"
    }
  ]
}
gniezen commented 5 months ago

@vojtech-cerveny There's a bug in electron-builder that hasn't been fixed for years. Unfortunately there's nothing that we can do about it, so the workarounds are:

I just did the second one. Keep in mind that this PR cannot be merged even though UPLOAD-1201 has been approved, as UPLOAD-1157 is also linked to this PR and still needs to be tested.