[TIMOB-25426] Automatically try to fix metabase permissions

tidev / hyperloop.next

Hyperloop Next version (we forgot the version number at this point)

Other

8 stars 5 forks source link

[TIMOB-25426] Automatically try to fix metabase permissions #243

Closed janvennemann closed 7 years ago

janvennemann commented 7 years ago

JIRA: https://jira.appcelerator.org/browse/TIMOB-25426

Didn't want to go for a hacky solution or move the folder structure again so i tried some kind of smart detection and fix the file permissions automatically. This will only be done if the initial spawning of the metabase binary fails, so no additional I/O overhead if the permissions are already correct.

Additionally cleaned up some unnecessary build steps for the metabase parser which can easily be accomplished by the use of a .npmignore together with npm pack.

hansemannn commented 7 years ago

@sgtcoolguy For a second look as you changed many parts of the script earlier.

hansemannn commented 7 years ago

Also:

Windows:
- The windows module is now missing again.
- The TitaniumWindows_Hyperloop/bin directory includes the Debug/ directory, is that required? (cc @infosia)
Android: The test directory of the Android metabase is included in the zip.
iOS: The filter.sh script is included for iOS. Not sure if that is actually used during app-build-time

ewanharris commented 7 years ago

@hansemannn I don't think that's caused by this PR, the Window module build looks to be missing the --run-cmake flag which is needed on first build to regenerate the projects (we could improve to default to true if no cmake files detected) https://jenkins.appcelerator.org/blue/organizations/jenkins/titanium-sdk%2Fhyperloop.next/detail/PR-243/3/pipeline/32

infosia commented 7 years ago

Right, according to the build log I see that the build script deletes rm -f CMakeLists.txt, then --run-cmake is required on appc run -p windows --build-only to re-generate CMakeLists.txt.

appc run -p windows --build-only --run-cmake

infosia commented 7 years ago

Until TIMOB-25433 is addressed, we should not remove CMakeLists.txt to workaround this. We should remove the line rm -f CMakeLists.txt from the batch.

infosia commented 7 years ago

FYI I'm working on #245, trying to make Windows build work.

infosia commented 7 years ago

@hansemannn I believe Windows bulid #245 and #246 is going through well. @ewanharris Could you take a quick review the code just in case? Feel free to merge then.

janvennemann commented 7 years ago

@hansemannn, addressed your comments.

filter.sh seems to be a script to strip framework architectures but is not used by Hyperloop, so we can probably drop it.

hansemannn commented 7 years ago

@sgtcoolguy We have no permissions to re-run Jenkins anymore, can you please retrigger.

hansemannn commented 7 years ago

The Jenkins errors look unrelated and due to network-issues. As the 2_2_X passes as well, we can merge here.