[TIMOB-26321] Fix new lines in locale strings

tidev / liveview

Titanium LiveTi (live preview of Titanium applications on device)

Other

7 stars 3 forks source link

[TIMOB-26321] Fix new lines in locale strings #116

Closed garymathews closed 6 years ago

garymathews commented 6 years ago

Decode new line statement \n into a new line

TEST CASE

i18n/en/strings.xml (not inside Resources)

<?xml version="1.0" encoding="UTF-8"?>
<resources>
  <string name="test">test\ntest</string>
</resources>

app.js

const win = Ti.UI.createWindow(),
  lbl = Ti.UI.createLabel({
    text: L('test')
  });
win.add(lbl);
win.open();

JIRA Ticket

ewanharris commented 6 years ago

@garymathews Apologies for me not making this known, 1_2_X has already bumped to 1.2.3, it contains #117 which should never land on master (i.e active development going forward), I only branched PR'd that change here to avoid any potential conflicts if we had to release another bug fix on top of that (so I guess this one 🙂).

So, if this is going into Studo, could you PR to 1_2_X also, the liveview code in titanium_studio#development is already synced with 1_2_X, but AFAIK not whatever the 5.1.2 branch represents as that change was not accepted into the 5.1.2 release.

ewanharris commented 6 years ago

Other PR is merged so merging this one