[TIMOB-24485] Revert TIMOB-23664 - Skip Windows virtual adapter

tidev / liveview

Titanium LiveTi (live preview of Titanium applications on device)

Other

7 stars 3 forks source link

[TIMOB-24485] Revert TIMOB-23664 - Skip Windows virtual adapter #99

Closed infosia closed 7 years ago

infosia commented 7 years ago

TIMOB-24485

Revert #94 because this adapter may be used to communicate to emulators. From what I see on the latest Win 10 SDK & emulators this adapter is actually used. So I think under the variety of user's network configurations we should not skip specific interface automatically but should provide a way to select preferred interface to use - which is implemented in #96 (CLI-1075).

infosia commented 7 years ago

@garymathews Do you think we want to pass it to in-qe-testing, or we just merge this now?

garymathews commented 7 years ago

I think we should mark for QE, since it could re-introduce https://jira.appcelerator.org/browse/TIMOB-23664

ewanharris commented 7 years ago

FR PASSED!

Windows 10 Pro
Ti SDK:  6.1.0.v20170514022959
Appc Core: 6.2.2-master.9
Appc NPM: 4.2.9
Node: 6.10.2

Able to build a classic Titanium app for wp-emulator, ws-local, and wp-device targets. On wp-emulator, a user must pass in the ip of the Internal Switch

Alloy app connects to server and fails on a file, will be fixed in: TIMOB-24699

Added TIDOC-2875 to review documentation to ensure it correctly reflects usage Windows platform (i.e. wp-emulator requiring --liveview-ip