search

tidev / node-ios-device

Queries connected iOS devices and installs apps
Other
122 stars 37 forks source link

chore(1_X): Node 13 and Catalina build support #54

Closed garymathews closed 4 years ago

garymathews commented 4 years ago
cb1kenobi commented 4 years ago

I am able to build for every Node version except 13.5.0. I'm using Node 12.13.0, Xcode 11.3, npm 6.13.4.

$ /Users/chris/.nvm/versions/node/v12.13.0/bin/node /Users/chris/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --target=13.5.0 --module=/Users/chris/appc/lib/node-ios-device/binding/node-v79-darwin-x64/node_ios_device.node --module_name=node_ios_device --module_path=/Users/chris/appc/lib/node-ios-device/binding/node-v79-darwin-x64 --napi_version=5 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v79 --python=/usr/bin/python

gyp info it worked if it ends with ok
gyp info using node-gyp@5.0.5
gyp info using node@12.13.0 | darwin | x64
gyp info find Python using Python version 2.7.16 found at "/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python"
gyp http GET https://nodejs.org/dist/v13.5.0/node-v13.5.0-headers.tar.gz
gyp http 200 https://nodejs.org/dist/v13.5.0/node-v13.5.0-headers.tar.gz
gyp http GET https://nodejs.org/dist/v13.5.0/SHASUMS256.txt
gyp http 200 https://nodejs.org/dist/v13.5.0/SHASUMS256.txt
gyp info spawn /System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python
gyp info spawn args [
gyp info spawn args   '/Users/chris/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/chris/appc/lib/node-ios-device/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/chris/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/chris/Library/Caches/node-gyp/13.5.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/Users/chris/Library/Caches/node-gyp/13.5.0',
gyp info spawn args   '-Dnode_gyp_dir=/Users/chris/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/Users/chris/Library/Caches/node-gyp/13.5.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/Users/chris/appc/lib/node-ios-device',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp: name 'v8_enable_pointer_compression' is not defined while evaluating condition 'v8_enable_pointer_compression == 1' in binding.gyp while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/Users/chris/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack     at ChildProcess.emit (events.js:210:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 19.2.0
gyp ERR! command "/Users/chris/.nvm/versions/node/v12.13.0/bin/node" "/Users/chris/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "--target=13.5.0" "--module=/Users/chris/appc/lib/node-ios-device/binding/node-v79-darwin-x64/node_ios_device.node" "--module_name=node_ios_device" "--module_path=/Users/chris/appc/lib/node-ios-device/binding/node-v79-darwin-x64" "--napi_version=5" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v79" "--python=/usr/bin/python"
gyp ERR! cwd /Users/chris/appc/lib/node-ios-device
gyp ERR! node -v v12.13.0
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok

I have to add the following variables in the binding.gyp:

    'variables': {
        'build_v8_with_gn': 'false',
        'v8_enable_pointer_compression': 'false',
        'v8_enable_31bit_smis_on_64bit_arch': 'false'
    },
cb1kenobi commented 4 years ago

This PR needs to also update the supported Node.js versions in the README.md.