tidev / node-ios-device

Queries connected iOS devices and installs apps
Other
122 stars 37 forks source link

Update node support #81

Closed m1ga closed 1 year ago

m1ga commented 1 year ago

See https://github.com/tidev/node-ios-device/pull/74 for details (its to support node 17)

node 19 tries to download https://github.com/tidev/node-ios-device/releases/download/v1.9.4/node_ios_device-v1.9.4-node-v111-darwin-arm64.tar.gz node 18 https://github.com/tidev/node-ios-device/releases/download/v1.9.4/node_ios_device-v1.9.4-node-v108-darwin-x64.tar.gz

cb1kenobi commented 1 year ago

Sigh... I'll have to commandeer the wife's MacBook Pro this weekend :)

ewanharris commented 1 year ago

I made #82 that achieves this, it's not perfect for sure but it's probably the quickest/path of least resistance to supporting newer versions of node without any changes in ioslib/the SDK itself

m1ga commented 1 year ago

Awesome, thanks @ewanharris :+1: Hope someone can test and merge that soon. I'll test everything on Linux in the next days to see if we'll need to update some other repo

cb1kenobi commented 1 year ago

Awesome, I'll give it a look hopefully tonight!