search

tidev / node-ios-device

Queries connected iOS devices and installs apps
Other
122 stars 37 forks source link

feat: add support for node 22 #88

Closed ewanharris closed 4 months ago

ewanharris commented 4 months ago

node-pre-gyp is still dead so update the patch we use to build and nan to bring in Node 22 compatibility, still outputs some deprecations but builds just fine. Tested locally and .devices works as expected and is able to load the binding, have not tested anything further as I don't have the ability to

Closes #87

cb1kenobi commented 4 months ago

@ewanharris Looks good and works, but CI is failing. Would you kindly bump the Node.js verision for the the build and publish CI scripts to Node 18 and see if that helps?

ewanharris commented 4 months ago

It looks like the issue is because of the python version which node-gyp fixed (nodejs/node-gyp/issues/2869), we need npm 10.2.2 or newer which 🤞🏻 should be in Node 18, if not I'll just add installing a new npm version

ewanharris commented 4 months ago

@cb1kenobi done and looks too be good!

cb1kenobi commented 4 months ago

node-ios-device@1.12.0 published