search

tidev / node-ios-device

Queries connected iOS devices and installs apps
Other
122 stars 37 forks source link

ci: use macos-13 to run ci #89

Closed ewanharris closed 3 months ago

ewanharris commented 3 months ago

There seems to be an issue with compiling node-ios-device for x64 on arm64 machines, unfortunately all MacOS 14 runners on GitHub are now arm64 based so we have to drop down to MacOS 13. We can verify it builds ok using the artifacts produced.

Realistically, this is a bandaid not a fix. There might be a genuine fix we can perform in the build logic but this is hopefully faster.

cb1kenobi commented 3 months ago

Or, give up on node-ios-device@1.X. It's a dead horse.

v3 in master is superior. You should update ioslib to use it by creating a 1_8_X branch from 1_7_X that uses node-ios-device@3.

ewanharris commented 3 months ago

Downloading the binding folder it looks to build correctly file /Users/awam/Downloads/binding/node-v127-darwin-x64/node_ios_device.node

ewanharris commented 3 months ago

@cb1kenobi I can try that out but I'd prefer to get a fixed version of this so that we can have something functional and then refactor