tidev / titanium-sdk

🚀 Native iOS and Android Apps with JavaScript
https://titaniumsdk.com/
Other
2.75k stars 1.21k forks source link

iOS: Ti.userAgent is incorrect #13254

Open hansemannn opened 2 years ago

hansemannn commented 2 years ago

I have searched and made sure there are no existing issues for the issue I am filing

Description

The Ti.userAgent is set incorrectly on iOS.

Expected Behavior

The Ti.userAgent property should be Appcelerator Titanium/10.2.0 (...).

Actual behavior

It returns Appcelerator Titanium/0.0.0 (...) on iOS. The same works fine on Android.

Reproducible sample

console.warn(Ti.userAgent);

Steps to reproduce

Run the above on iOS.

Platform

iOS

SDK version you are using

10.2.0

m1ga commented 2 years ago

Maybe a dev/production build issue?

https://github.com/appcelerator/titanium_mobile/blob/fe3deddcea07ecb3555673cf2dba8d676fd79611/iphone/TitaniumKit/TitaniumKit/Sources/API/TiBase.h#L483-L488 sets it to 0.0.0 if not defined. But it is set here: https://github.com/appcelerator/titanium_mobile/blob/ead1713e5e36b4632b692ce6fcc9a9785b91ad26/iphone/cli/commands/_build.js#L4601 and if I look in the project.xconfig I see that TI_VERSION is set to 10.1.1.