search

tidev / titanium-sdk

🚀 Native iOS and Android Apps with JavaScript
https://titaniumsdk.com/
Other
2.75k stars 1.21k forks source link

Build. Github artifacts #13333

Open drauggres opened 2 years ago

drauggres commented 2 years ago

Artifacts from github actions are zipped twice. i.e. you can't download an artifact and then run ti sdk install <mobilesdk-version.zip>.

Maybe we could skip zip creation and create github artifacts from raw files.

https://github.com/actions/upload-artifact#zipped-artifact-downloads

ewanharris commented 2 years ago

I took a stab at seeing how this would work using the existing --skip-zip flag on scons package and this is the resulting build, it looks like it uploading the raw assets causes the upload time to increase massively.

Maybe an alternative here is to improve this on the SDK install side to handle a double zipped SDK?

ewanharris commented 2 years ago

PR that attempts the above here https://github.com/tidev/titanium/pull/559