search

tidev / titanium-sdk

🚀 Native iOS and Android Apps with JavaScript
https://titaniumsdk.com/
Other
2.76k stars 1.21k forks source link

fix: sdk build on windows needs shell: true to run batch files #14095

Closed cb1kenobi closed 3 months ago

cb1kenobi commented 3 months ago

Not sure if it's a Node 22 thing or what, but I get a EINVAL error doing npm run cleanbuild:local because it spawns a batch file which requires a shell to be true.

m1ga commented 3 months ago

I'll get my VM setup to build the SDK and check it

m1ga commented 3 months ago

yes, it's a node 22 thing. With node 20 I didn't see that error. When I updated I saw:

Bildschirmfoto_20240815_121758 (don't have copy & paste running, so screenshot was quicker :smile: )

After this PR it starting building again. It's still at 48% for 5mins now but I blame the VM for that... Update: 10mins later and it finished building :smile:

Building with 22.5.0 under linux still works fine with the current master but I see many

(node:24216) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

warnings during the build process.

cb1kenobi commented 3 months ago

Awesome, thank you guys for the review! Let's go!