search

tidev / titanium-sdk

🚀 Native iOS and Android Apps with JavaScript
https://titaniumsdk.com/
Other
2.76k stars 1.21k forks source link

Notification Channel not up to date docs #14106

Closed Informate closed 2 months ago

Informate commented 2 months ago

I have searched and made sure there are no existing issues for the issue I am filing

URL

https://titaniumsdk.com/api/titanium/android/notificationchannel.html

Description

In the example a non existent method getId is used, while the doc for the audioStreamType attribute seems merged into the importance attribute docs. The audioStreamType results undocumented and the correct availables values are unknown.

Suggestion

X

m1ga commented 2 months ago

getId() is just .id now: https://titaniumsdk.com/api/titanium/android/notificationchannel.html#properties_id it's the old getter/setter update in Ti 10.

audiostreamtype is here: https://titaniumsdk.com/api/titanium/android/notification.html#audiostreamtype

You can also fork the repo and make the changes. Pull requests are always welcome!

m1ga commented 2 months ago

fix: https://github.com/tidev/titanium-sdk/pull/14107

Informate commented 2 months ago

Super fast fixing :)))

m1ga commented 2 months ago

No problem :smile: :+1: