Closed m1ga closed 1 week ago
This will just add a note to the docs now. As many people still use the old M2 themes and I've started a rewrite of the BottomNavigation in a different PR it should be enough for now. If you use a M3 theme you have to add the XML file with the height yourself
It can only be seen as a workaround, as we definitely need the "clean" solution from the other PR
New PR:
I've only add the note in the docs as I've started a rewrite of the BottomNavigation in another PR.
Old PR (just as a reference):
SO issue in native land: https://stackoverflow.com/questions/72062902/how-do-i-get-the-bottom-navigation-bar-height-for-material-design-3 and some screenshots.
Currently we use
design_bottom_navigation_height
for the height of the bottom navigation (56dp). It looks like Material 3 is usingm3_bottom_nav_min_height
(80dp).We need to check if the app is using a Material3 theme and then use the new dimens value.
Test
Yellow text field should be fully visible in the tab.
Questions: Can we use
activity.getTheme().toString().indexOf("Material3")
to check for Material3 theme?Workaround If you use M3 in your app you can add
/app/platform/android/res/values/dimens.xml
withto override the current value.