search

tidev / titanium-sdk

🚀 Native iOS and Android Apps with JavaScript
https://titaniumsdk.com/
Other
2.76k stars 1.21k forks source link

Android CLI: Missing () in Error Reporting funciton #14127

Closed Informate closed 1 month ago

Informate commented 1 month ago

I have searched and made sure there are no existing issues for the issue I am filing

Description

Building I recived an error (over another Error)

[LiveView] TypeError: err.toString.split is not a function at /home/UserName/.titanium/mobilesdk/linux/12.5.0.GA/android/cli/hooks/run.js:90:20

Change (android/cli/hooks/run.js, line 90):

err.toString.split('\n').forEach(logger.error);

in

err.toString().split('\n').forEach(logger.error);

Expected Behavior

X

Actual behavior

X

Reproducible sample

X

Steps to reproduce

X

Platform

CLI

SDK version you are using

12.5.0

Alloy version you are using

No response

cb1kenobi commented 1 month ago

Whoops. My bad. What was I thinking.... 11 years ago! https://github.com/tidev/titanium-sdk/commit/a17e4df9ce774b068cf467a7e0b026b5eb9645d7

m1ga commented 1 month ago

Whoops. My bad. What was I thinking.... 11 years ago! a17e4df

Guess nobody had the error case before :) But nice that it's fixed :+1: