search

tidev / titanium-sdk

🚀 Native iOS and Android Apps with JavaScript
https://titaniumsdk.com/
Other
2.76k stars 1.21k forks source link

feat(ios): added support for iOS 18 dark mode icons #14137

Open AbdullahFaqeir opened 1 month ago

AbdullahFaqeir commented 1 month ago

As mentioned this issue #14122, this was missing.

dlewis23 commented 1 month ago

We have to also update the _build.js file to add the dark and tinted icons. Also have tell it to not flatten against a white background. The dark mode icon is not suppose to have a background the system adds a gradient background automatically.

Attached is my _build.js file. I'm sure there is a better way to handle not flattening against a white background.

_build.js.zip

hansemannn commented 1 month ago

@dlewis23 You can do a PR to @AbdullahFaqeir's branch, then it appears here in the PR once that PR is merged :)

dlewis23 commented 1 month ago

@hansemannn I tried to make a PR to it, but Github desktop keeps giving me an error when I try and publish the PR which I have not been able to figure out yet.

dlewis23 commented 1 month ago

I can't do a PR to @AbdullahFaqeir branch, it gives an error every time, but somehow went down a loop and ended up making a new PR here on accident with the changes: https://github.com/tidev/titanium-sdk/pull/14138