search

tidev / titanium-sdk

🚀 Native iOS and Android Apps with JavaScript
https://titaniumsdk.com/
Other
2.76k stars 1.21k forks source link

feat(ios): reviving PR #12411 for ios background tasks #14142

Open AbdullahFaqeir opened 1 week ago

AbdullahFaqeir commented 1 week ago

This PR is solely to revive PR #12411

AbdullahFaqeir commented 1 week ago

@hansemannn @m1ga if we can check this

m1ga commented 1 week ago

@AbdullahFaqeir I think you are still on a different branch as I can see some of your "ios dark mode icons" stuff in there.

AbdullahFaqeir commented 1 week ago

@AbdullahFaqeir I think you are still on a different branch as I can see some of your "ios dark mode icons" stuff in there.

@m1ga already cleaned up

m1ga commented 1 week ago

checked the changed files: it still has https://github.com/tidev/titanium-sdk/pull/14142/files#diff-2c47f46b98744ab36764749bd8937002f06e1293a9b41d4ff2e12c1790e47d77

AbdullahFaqeir commented 1 week ago

I only reverted the file to it's original content from the main repo

m1ga commented 1 week ago

That part (and the other file you reverted already) is from your other PR: https://github.com/tidev/titanium-sdk/pull/14137/files . It looks like you didn't start from the master branch to start the PR but from this branch ios-dark-mode-icons