tidev / titanium-sdk

🚀 Native iOS and Android Apps with JavaScript
https://titaniumsdk.com/
Other
2.76k stars 1.21k forks source link

Android: Update v8 #14143

Open m1ga opened 1 week ago

m1ga commented 1 week ago

I have searched and made sure there are no existing issues for the issue I am filing

Description

I've tested https://github.com/tidev/v8_titanium/releases/tag/v9.4.146.16 again and I don't have any issue with it. We had this issue: https://github.com/tidev/titanium-sdk/issues/13395

but I've tested it with 12.6.0 again and compiled a module with it and used it with 12.5.1.GA and I didn't see the crash. Maybe we should give it another try and see if it works.

I did patch the old issue and had a working build: https://github.com/tidev/v8_titanium/pull/55 but that action doesn't run anymore so I can't build it anymore :( This was the fix https://github.com/tidev/v8_titanium/pull/55/files#diff-4f2f329447fc899a9eadda6a27ac58bbb97ef773991b42367e35c73a15b5adcd but it looks like we don't need it. Android 14, Pixel 9 Pro.

Thinks we should do:

Solution

-

Alternatives

No response

Platforms

Android

AbdullahFaqeir commented 5 days ago

@m1ga and definitely this