search

tideways / php-xhprof-extension

This XHProf PHP extension fork has outlived its purpose and is archived in favor of the revitalized https://github.com/longxinH/xhprof
https://tideways.com
Apache License 2.0
1.63k stars 208 forks source link

./configure: line 4107: syntax error: unexpected #100

Closed ChrisB9 closed 3 years ago

ChrisB9 commented 4 years ago

Hi there,

I am currently building the xhprof-extension in a php8 environment Since the newest php release php 8.0.0beta1 the configure execution renders the following error:

./configure: line 4107: syntax error: unexpected "(" (expecting "fi")

image $as_echo_n "(cached) " >&6 -> this line is the culprit of that error.

I guess, something changed in the php-src developer-flags which in return triggers this.

The error is reproducable using this docker-setup: https://github.com/ChrisB9/php8-xdebug

beberlei commented 4 years ago

Probably Alpines configure is a different version or something where the syntax is slightly different than on a common Linux ;-)

ChrisB9 commented 4 years ago

That would mean, that the configuration should have never worked. The last change in this repository happend in April and i am pulling from master. Prior to Thursday, hence in the alpha3, it worked. I don't really think it is alpines fault here.

Edit: i just realized, i did not fully copy the entire error message - i added that now

Edit 2: In the attached docker image, i replaced FROM php:8.0.0beta1-fpm-alpine with FROM php:8.0.0alpha3-fpm-alpine -> this extension compiles flawlessly :)

khs1994 commented 4 years ago

@nikic

nikic commented 4 years ago

Should be fixed by https://github.com/php/php-src/commit/05478e985eb50c473054b4f1bf174f48ead78784.