search

tidwall / SwiftWebSocket

Fast Websockets in Swift for iOS and OSX
MIT License
1.53k stars 246 forks source link

Objective-C support #19

Closed ricardopereira closed 8 years ago

mattheworiordan commented 8 years ago

Looks good @ricardopereira :)

Worth having a few high level tests perhaps from Obj-C to prove interoperability firstly, but also to ensure there are no regressions? I expect this can be done easily with some very high level tests just checking that the interface works as expected.

tidwall commented 8 years ago

@ricardopereira Very cool! I did a cursory review and I don't see anything alarming. l'll poke around a bit and test it in some of my projects.

tidwall commented 8 years ago

It passes all the Autobahn tests and runs fine in swift as far as I can tell. I haven't tested it with objective-c yet. At this point we should probably have a simple unit test specifically for objective-c that binds all the delegate methods. Ideally connecting to an echo service similar to the example code in the Readme.

ricardopereira commented 8 years ago

@mattheworiordan @tidwall Tests done #20.