search

tidyfun / tf

S3 classes and methods for tidy functional data
https://tidyfun.github.io/tf/
GNU Affero General Public License v3.0
6 stars 2 forks source link

refactor: removing and simplifying imports #105

Closed m-muecke closed 3 months ago

m-muecke commented 3 months ago

Closes: https://github.com/tidyfun/tf/issues/94

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.09%. Comparing base (f5a2eec) to head (13b1cba). Report is 50 commits behind head on dev.

Files Patch % Lines
R/tfb-spline.R 71.42% 2 Missing :warning:
R/convert.R 0.00% 1 Missing :warning:
R/tfb-fpc.R 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #105 +/- ## ========================================== - Coverage 74.36% 74.09% -0.28% ========================================== Files 28 28 Lines 1771 1957 +186 ========================================== + Hits 1317 1450 +133 - Misses 454 507 +53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fabian-s commented 3 months ago

thanks --

m-muecke commented 3 months ago

thanks --

  • did you do this manually or use some kind of script to find the relevant LOCs? if the latter, could you post it here?
  • why zoo::bla for some functions and importFrom zoo blub for others?
  1. no script, I just greping in vim
  2. I wanted to use namespace prefix for zoo functions, but due to the get() call @importFrom zoo rollmean rollmedian was needed for having them in the namespace. If you like I can import the other zoo functions, I just didn't want the entire zoo package imported like before
fabian-s commented 3 months ago

If you like I can import the other zoo functions, I just didn't want the entire zoo package imported like before

I would prefer that, for consistency

m-muecke commented 3 months ago

If you like I can import the other zoo functions, I just didn't want the entire zoo package imported like before

I would prefer that, for consistency

done