search

tidyfun / tf

S3 classes and methods for tidy functional data
https://tidyfun.github.io/tf/
GNU Affero General Public License v3.0
5 stars 2 forks source link

replace magrittr with native pipes #23

Closed fabian-s closed 8 months ago

jeff-goldsmith commented 3 years ago

makes sense to remove magrittr as a dependency (although i still kinda shudder at native pipes ...)

what's a good timeline for this? will we wait until the new R version is pretty prevalent among users, since it'll be required?

fabian-s commented 3 years ago

makes sense to remove magrittr as a dependency (although i still kinda shudder at native pipes ...)

yeah, but not sure it makes sense anymore because native pipe can't do stuff like x %>% { some_function(bla, bloo, ble, .x) } which I think I've used a number of times, and the magrittr-pipe comes with the other tidyverse-imports anyway, I think....

what's a good timeline for this? will we wait until the new R version is pretty prevalent among users, since it'll be required? definitely wait a while

fabian-s commented 2 years ago

closing this for now. might have to revisit in context of tidyfun/tidyfun#69

fabian-s commented 2 years ago

native pipe supports ploaceholders starting at 4.2: https://davidbudzynski.github.io/general/2022/04/23/r-native-placeholder.html