search

tidyfun / tf

S3 classes and methods for tidy functional data
https://tidyfun.github.io/tf/
GNU Affero General Public License v3.0
6 stars 2 forks source link

ci: use check-standard for main branch rcmdcheck and upload snapshots for dev branch #72

Closed m-muecke closed 5 months ago

codecov-commenter commented 5 months ago

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (bacd1c5) 71.73% compared to head (a3cf54c) 71.15%. Report is 13 commits behind head on dev.

:exclamation: Current head a3cf54c differs from pull request most recent head a49589b. Consider uploading reports for the commit a49589b to get more accurate results

Files Patch % Lines
R/methods.R 0.00% 18 Missing :warning:
R/print-format.R 0.00% 4 Missing :warning:
R/summarize.R 0.00% 3 Missing :warning:
R/fwise.R 75.00% 2 Missing :warning:
R/ops.R 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #72 +/- ## ========================================== - Coverage 71.73% 71.15% -0.58% ========================================== Files 27 27 Lines 1705 1723 +18 ========================================== + Hits 1223 1226 +3 - Misses 482 497 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fabian-s commented 5 months ago
  1. i think we do want the full check across the different OS types for main because that's what CRAN does too.
  2. what are snapshots and why do we want them? (asks the old man)
m-muecke commented 5 months ago
  1. i think we do want the full check across the different OS types for main because that's what CRAN does too.
  2. what are snapshots and why do we want them? (asks the old man)
  1. the PR is for the "full-check" which is actually the check-standard.yaml the full-check.yaml is only really relevant for tidyverse packages since it tests against older R versions (3.6) so its not relevant for the package.
  2. those are from snapshot testing in testthat: https://testthat.r-lib.org/articles/snapshotting.html currently I believe not relevant for current tests, but good to have as a default option and used by the tidyverse packages in the CI: https://github.com/tidyverse/dplyr/blob/main/.github/workflows/R-CMD-check.yaml#L60
fabian-s commented 5 months ago

  1. I misread the diff, sorry. You're right, of course.

  2. Thanks for the explanation. Yes, that might become useful going forward!