search

tidyfun / tf

S3 classes and methods for tidy functional data
https://tidyfun.github.io/tf/
GNU Affero General Public License v3.0
5 stars 2 forks source link

shore up defenses: constructors need proper validation, more input checks #9

Closed fabian-s closed 7 months ago

fabian-s commented 5 years ago

e.g.: currently no checks for domain, that domain and arg match, that resolution is sensible etc

m-muecke commented 7 months ago

Should there be other checks for the domain besides checking if its matching with the arg? What would be sensible checks for the resolution?

fabian-s commented 7 months ago

not sure actually. fixed the most egregious gaps and closing this for now until we come across actual bugs/problems caused by weird resolutions etc.