tidyfun / tf

S3 classes and methods for tidy functional data
https://tidyfun.github.io/tf/
GNU Affero General Public License v3.0
5 stars 2 forks source link

refactor: use assignment operator, use leading zero, one call to format_bib #92

Closed m-muecke closed 3 months ago

m-muecke commented 4 months ago

@fabian-s have a look when its convenient, most the changes are already reflected in the package, i.e. mainly consistency changes

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 72.91667% with 26 lines in your changes missing coverage. Please review.

Project coverage is 74.06%. Comparing base (f5a2eec) to head (dd3ea69). Report is 16 commits behind head on dev.

:exclamation: Current head dd3ea69 differs from pull request most recent head 75679ab

Please upload reports for the commit 75679ab to get more accurate results.

Files Patch % Lines
R/rebase.R 22.22% 7 Missing :warning:
R/ops.R 73.33% 4 Missing :warning:
R/soft-impute-svd.R 63.63% 4 Missing :warning:
R/methods.R 0.00% 3 Missing :warning:
R/fwise.R 80.00% 2 Missing :warning:
R/summarize.R 84.61% 2 Missing :warning:
R/utils.R 66.66% 2 Missing :warning:
R/tfd-class.R 66.66% 1 Missing :warning:
R/vctrs-ptype2.R 83.33% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #92 +/- ## ========================================== - Coverage 74.36% 74.06% -0.30% ========================================== Files 28 28 Lines 1771 1770 -1 ========================================== - Hits 1317 1311 -6 - Misses 454 459 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fabian-s commented 3 months ago

nice! thank you :)