Open m-muecke opened 1 month ago
Nitpicking, but there are duplicate package imports for purrr https://github.com/tidyfun/tf/blob/dev/R/tfd-class.R#L1 and https://github.com/tidyfun/tf/blob/dev/R/tfd-class.R#L1 while also import the functions https://github.com/tidyfun/tf/blob/dev/R/fwise.R#L17and using it with the explicit namespace: https://github.com/tidyfun/tf/blob/dev/R/fwise.R#L51 the same is true for the mgcv and stats imports.
Suggestion would be to move the whole package imports (i.e. @import purrr to the R/tf-package.R file like done in dplyr or other many other packages: https://github.com/tidyverse/dplyr/blob/main/R/dplyr.R#L6
@import purrr
Nitpicking, but there are duplicate package imports for purrr https://github.com/tidyfun/tf/blob/dev/R/tfd-class.R#L1 and https://github.com/tidyfun/tf/blob/dev/R/tfd-class.R#L1 while also import the functions https://github.com/tidyfun/tf/blob/dev/R/fwise.R#L17and using it with the explicit namespace: https://github.com/tidyfun/tf/blob/dev/R/fwise.R#L51 the same is true for the mgcv and stats imports.
Suggestion would be to move the whole package imports (i.e.
@import purrrto the R/tf-package.R file like done in dplyr or other many other packages: https://github.com/tidyverse/dplyr/blob/main/R/dplyr.R#L6