search

tidymodels / .github

GitHub contributing guidelines for tidymodels packages
MIT License
4 stars 0 forks source link

Change locking activity on inactive issues #2

Open brshallo opened 3 years ago

brshallo commented 3 years ago

I request that old inactive (locked for comments) issues on tidymodels ( / tidyverse) packages still accumulate links when they are referenced in new issues or PRs. That way, users perusing old closed issues will be more easily linked to the most up-to-date issue(s) on a topic. (Particularly with locks happening after just 14 days after close.)

For example tidymodels/tune#215 was closed and locked. I opened and closed tidymodels/tune#381 with the intention that a link would be added at the bottom of #215 (as I'd referenced it) for anyone trying to do something similar. Yet because #215 was locked, no link to #381 was added. (This is an imperfect example as maybe I shouldn't have created #381 as it's essentially just a comment on a closed issue -- rather than a genuine bug or feature request -- which you are trying to limit. However in most cases continuing to accumulate links on old issues to newer topics may be valuable for people searching a pakcages github issues for some problem they are facing. I wonder if there is some middle ground here that allows for linking after comments are locked and doesn't leave issues overrun and tidymodels / tidyverse team slammed with notifications.)

juliasilge commented 3 years ago

Ah, we can link to the locked issues and have the link show up because we are "collaborators" on each repo but other contributors or users cannot.

I don't believe there is a way to lock the issues and still allow external folks to link to it with a visible reference (I guess that is kind of the point) so maybe we should update our wording on the locked issues? I do think it may still be useful direction for folks to put in a link to something they want further addressed, even if a reference isn't autogenerated. 🤔

brshallo commented 3 years ago

Posted idea for being able to lock issues and still accrue references: https://github.com/github/feedback/discussions/4850 (no response). Perhaps I just prefer being able to occasionally pollute your closed issues at my leisure 😅.

Wording is fine. Maybe could change:

"and link to this issue" to "and include a link to this issue" (which might be more clear to user are not "linking" the issue via github's automatic cross-linking, but simply including a URL on the new issue, but probably doesn't matter either way... I could do a PR, otherwise could close.)

brshallo commented 3 years ago

I think why I like the idea of allowing references on closed issues is related to the practices I try to follow regarding cross-posting:

:link: Always link to your other posts, and update everywhere with any solutions

-Rstudio Community FAQ: Is it OK to Cross-Post

(Though of course the practices for help sites are different from those for github.)

juliasilge commented 3 years ago

I am very similar and like to cross-link a lot so I can easily find things later. For now, we do want to keep the lock files functioning as they are (not any great alternatives at this moment) and I think there is still value in encouraging people to add a link to something they want to see further addressed, even if there is no autogenerated, visible link created on both sides.

I do think your suggested wording is a bit better and more clear; let's at least update that here and then we can eventually get it updated on all the repos.