tidymodels / TMwR

Code and content for "Tidy Modeling with R"
https://tmwr.org
Other
586 stars 275 forks source link

Chapter 16 typos and duplicate code chunks #301

Closed gunnergalactico closed 2 years ago

gunnergalactico commented 2 years ago

Online version of book.

chapter 16.1 reads:

"16.1 WHEN PROBLEMS CAN DIMENSIONALITY REDUCTION SOLVE?"

16.5.1 Principal Component Analysis repeats a code chunk.

"bean_rec_trained %>% step_pca(all_numeric_predictors(), num_comp = 4) %>% plot_validation_results() + ggtitle("Principal Component Analysis")"

16.5.2 Partial Least Squares repeats a code chunk.

"bean_rec_trained %>% step_pls(all_numeric_predictors(), outcome = "class", num_comp = 4) %>% plot_validation_results() + ggtitle("Partial Least Squares")"

16.5.3 Independent Component Analysis

"bean_rec_trained %>% step_ica(all_numeric_predictors(), num_comp = 4) %>% plot_validation_results() + ggtitle("Independent Component Analysis")"

16.5.4 UNIFORM MANIFOLD APPROXIMATION AND PROJECTION repeats code chunk

"library(embed) bean_rec_trained %>% step_umap(all_numeric_predictors(), num_comp = 4) %>% plot_validation_results() + ggtitle("UMAP")"

"bean_rec_trained %>% step_umap(all_numeric_predictors(), outcome = "class", num_comp = 4) %>% plot_validation_results() + ggtitle("UMAP (supervised)")"

Thank you for all your hard work.

juliasilge commented 2 years ago

Can you give us a little more info about the problems you are seeing? I believe this is as intended. Notice that the PCA section uses step_pca(), the PLS section uses step_pls(), and so forth.

gunnergalactico commented 2 years ago

16 - reprex.pdf

Attached is a screenshot, not sure if it's my browser. I use safari and chrome. Thank you.

juliasilge commented 2 years ago

Ah, I see what you're saying now. Thank you so much! 🙌

github-actions[bot] commented 2 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.