search

tidymodels / TMwR

Code and content for "Tidy Modeling with R"
https://tmwr.org
Other
579 stars 272 forks source link

Chapter 11 code: Adding code to create ames_test in first recipe setup #355

Closed mpettis closed 1 year ago

mpettis commented 1 year ago

In the opening to chapter 11, there is a creation of a basic recipe for a workflow set. It uses the ames_train dataset from prior chapters. It looks as if the opening script should be stand alone. If so, the ames_train dataset should be created in that snippet. This pull request adds the creation of that dataset.

juliasilge commented 1 year ago

Thanks so much for reading @mpettis! 🙌 We have pretty carefully structured the code at the end and beginning of each chapter, to balance clarity and not repeating too much code at the beginning of each chapter. For example, see the end of Ch 5 and the first code in Ch 6. Each of the chapters' summaries has the code needed for moving forward. I can see how if you came to the beginning of Ch 11 directly, you might expect that it would be standalone code, but in the context of the book as a whole, that is a consistent treatment.

Thank you again for reading and the feedback!

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.