search

tidymodels / agua

Create and evaluate models using 'tidymodels' and 'h2o'
https://agua.tidymodels.org
Other
21 stars 2 forks source link

update GHA #45

Closed hfrick closed 1 year ago

hfrick commented 1 year ago

Do the checks on old releases always fail? If so, I'd comment them out rather than remove them so that it's a bit more obvious when updating 😃

hfrick commented 1 year ago

The checks on windows fail because of the last purrr update which will be resolved soon on the purrr side

hfrick commented 1 year ago

tagging both @qiushiyan and @topepo for review - not sure who's better to ask?

qiushiyan commented 1 year ago

Do the checks on old releases always fail? If so, I'd comment them out rather than remove them so that it's a bit more obvious when updating 😃

Yes I never got it working on the old versions on linux and windows :( Commenting them out is good.

qiushiyan commented 1 year ago

Do we also want to comment out the windows tests?

hfrick commented 1 year ago

Up to you. Initially, they failed because of the thing in purrr (affecting parsnip), but that has been solved. Not sure why they fail now. 

* checking examples ...Warning in file(con, "r") :
  cannot open file 'agua-Ex.Rout': Permission denied
Error: Error in file(con, "r") : cannot open the connection
Execution halted
hfrick commented 1 year ago

ah, just re-read your comment about the windows tests never really working. I've commented them out for now 👍

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.