search

tidymodels / agua

Create and evaluate models using 'tidymodels' and 'h2o'
https://agua.tidymodels.org
Other
21 stars 2 forks source link

Allow other preprocessors #9

Closed qiushiyan closed 2 years ago

qiushiyan commented 2 years ago

This PR should allow tuning when there is no recipe and other types of preprocessors #5.Not sure if we need to change this line https://github.com/topepo/agua/blob/e789ffa750262ffb31c46c50c41e755e9a8cd9d5/R/tune.R#L27 seems to work when there is no recipe.

We also need additional internal tune functions forge_from_workflow and finalize_workflow_preprocessor

topepo commented 2 years ago

That that line is fine.

I think that it's time to add tests (with recipes, formulas, and variable specifications). They'll have to skip for now but we can run them locally.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.