Open david-cortes opened 8 months ago
I am the maintainer of package isotree which is a dependency of {applicable} in CRAN under 'Suggests': https://cran.r-project.org/web/packages/applicable/index.html
I would like to push an update to {isotree} which would break one of the unit tests of {applicable}.
In particular, I would like to change the default argument ndim to function isolation.forest: https://github.com/david-cortes/isotree/blob/ad49b9717b41ce9bab86f2aeebe742679f0fca58/R/isoforest.R#L996 From the current (CRAN) default of min(3, NCOL(data)) to 1.
ndim
isolation.forest
min(3, NCOL(data))
1
This would generate a problem in this unit test for {applicable}: https://github.com/cran/applicable/blob/b66153447194c71778f7c04bc258722cc5cc5257/tests/testthat/test-isolation-fit.R#L26
To get the old behavior, one would now need to pass ndim=2 in this test:
ndim=2
res_rec <- apd_isolation(rec, cells_tr, ntrees = 10, nthreads = 1, ndim = 2),
Would be ideal if an updated version with this change could be submitted to CRAN.
Leaving it as an issue instead of PR as it looks like the code here is out of synch with the CRAN release and doesn't have the problematic file commited here.
I am the maintainer of package isotree which is a dependency of {applicable} in CRAN under 'Suggests': https://cran.r-project.org/web/packages/applicable/index.html
I would like to push an update to {isotree} which would break one of the unit tests of {applicable}.
In particular, I would like to change the default argument
ndimto functionisolation.forest: https://github.com/david-cortes/isotree/blob/ad49b9717b41ce9bab86f2aeebe742679f0fca58/R/isoforest.R#L996 From the current (CRAN) default ofmin(3, NCOL(data))to1.This would generate a problem in this unit test for {applicable}: https://github.com/cran/applicable/blob/b66153447194c71778f7c04bc258722cc5cc5257/tests/testthat/test-isolation-fit.R#L26
To get the old behavior, one would now need to pass
ndim=2in this test:Would be ideal if an updated version with this change could be submitted to CRAN.
Leaving it as an issue instead of PR as it looks like the code here is out of synch with the CRAN release and doesn't have the problematic file commited here.