tidymodels / broom

Convert statistical analysis objects from R into tidy format
https://broom.tidymodels.org
Other
1.45k stars 302 forks source link

Silence name repair #1182

Closed olivroy closed 10 months ago

olivroy commented 10 months ago

Using unique_quiet instead of unique.

the tidy_svd method produces many messages to the console right now. This PR silences them

I captured some conditions with & (unrelated) that I can revert if you'd like

simonpcouch commented 10 months ago

Thank you for the PR! Could you provide a reprex demonstrating where you see name repair issues arising?

simonpcouch commented 10 months ago

Removing the transitions from & to && would be great, yes. Feel free to file a separate PR/issue if you see errors resulting from their usage.

olivroy commented 10 months ago

From the tests:

library(modeltests)
#> Warning: le package 'modeltests' a été compilé avec la version R 4.3.2
library(broom)
mat <- scale(as.matrix(USJudgeRatings))
s <- svd(mat)
p <- prcomp(mat)
tdu <- tidy(s, matrix = "u")
#> New names:
#> • `` -> `...1`
#> • `` -> `...2`
#> • `` -> `...3`
#> • `` -> `...4`
#> • `` -> `...5`
#> • `` -> `...6`
#> • `` -> `...7`
#> • `` -> `...8`
#> • `` -> `...9`
#> • `` -> `...10`
#> • `` -> `...11`
#> • `` -> `...12`
tdd <- tidy(s, matrix = "d")
tdv <- tidy(s, matrix = "v")
#> New names:
#> • `` -> `...1`
#> • `` -> `...2`
#> • `` -> `...3`
#> • `` -> `...4`
#> • `` -> `...5`
#> • `` -> `...6`
#> • `` -> `...7`
#> • `` -> `...8`
#> • `` -> `...9`
#> • `` -> `...10`
#> • `` -> `...11`
#> • `` -> `...12`

Created on 2023-12-05 with reprex v2.0.2

github-actions[bot] commented 9 months ago

This pull request has been automatically locked. If you believe the issue addressed here persists, please file a new PR (with a reprex: https://reprex.tidyverse.org) and link to this one.