tidymodels / butcher

Reduce the size of model objects saved to disk
https://butcher.tidymodels.org/
Other
131 stars 12 forks source link

Fix argument name for `initial_split()` #259

Closed hfrick closed 1 year ago

hfrick commented 1 year ago

Several examples used rsample::initial_split() with an argument props which is a misspelling of the actual argument name prop.

This got surfaced in https://github.com/tidymodels/rsample/pull/429 where we now check the dots more tightly.

hfrick commented 1 year ago

Yes, it does but there is no immanent rsample release pending. I'd ping you if we are gearing up for that before the next "natural" butcher release 🔪

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.