search

tidymodels / censored

Parsnip wrappers for survival models
https://censored.tidymodels.org/
Other
123 stars 12 forks source link

Update tests #208

Closed hfrick closed 2 years ago

hfrick commented 2 years ago

Testing the model type (proportional_hazards() and survival_reg()) is better done in parsnip than censored. I looked at moving the tests to parsnip but: parsnip used to have them and got updated so I don't think it makes sense to re-add them.

The heritage tests on model fitting / execution for survival_reg() (inheriting from surv_reg()) have been updated to check the resulting model fit object, like the tests for the other model type / engines in censored.

hfrick commented 2 years ago

After our discussion I've added tests for primary args and engine args back in for the two model types which do not have any engines in parsnip: survival_reg() and proportional_hazards(), see https://github.com/tidymodels/parsnip/pull/791

github-actions[bot] commented 2 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.