Safeguards for `time` values of `NA`?

tidymodels / censored

Parsnip wrappers for survival models

https://censored.tidymodels.org/

Other

123 stars 12 forks source link

Safeguards for `time` values of `NA`? #220

Closed hfrick closed 1 year ago

hfrick commented 2 years ago

    Should we put in safeguards for time values of `NA`

_Originally posted by @topepo in https://github.com/tidymodels/censored/pull/216#discussion_r986008342_

hfrick commented 2 years ago

Options:

a warning and removal of the NA from the time vector
NA values for all the associated predictions (survival probability, confidence intervals, etc)
something else?

hfrick commented 1 year ago

this is now addressed in parsnip:::.filter_eval_time() which gets called in predict_survival() and predict_hazard() so this happens before the time values are passed to censored.

https://github.com/tidymodels/parsnip/blob/865e18f5aa848f08178ed255723852926689fe89/R/predict_survival.R#L22

github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.