Closed hfrick closed 1 year ago
@simonpcouch The changes are pretty boring to read - the more challenging aspect is if I overlooked anything to add. If you could tilt your review toward that, that'd be great! :raised_hands:
Thank you! The .time
vectors are indeed false positives. I plan on changing those when I make up my mind between calling them observed times or event times. The other ones were very helpful, thanks!
CI failures are due to changes in the new pillar, so unrelated to this PR
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
Closes #241
This PR completes the deprecation of the
time
argument to the prediction functions in favor of theeval_time
argument name laid out in https://github.com/tidymodels/parsnip/issues/892.The commits are (mostly) working through the package model/engine combination by model/engine combination, but the aggregated pattern is
-data.R
files, prediction modules fortype
s"survival"
and"hazard"
need to expect theeval_time
arg instead of thetime
argsurvival_prob_coxph()
, also make the switch and since they are exported,time
is being deprecated. Since they are also@keywords internal
, there are no specific deprecation tests. Happy to add those but thought that this might be a bit much.eval_time
where appropriate.time
arg inparsnip::predict_survival()
andparsnip::predict_hazard()
are intest-survival_reg-survival.R