tidymodels / censored

Parsnip wrappers for survival models
https://censored.tidymodels.org/
Other
123 stars 12 forks source link

`time` to `eval_time` #244

Closed hfrick closed 1 year ago

hfrick commented 1 year ago

Closes #241

This PR completes the deprecation of the time argument to the prediction functions in favor of the eval_time argument name laid out in https://github.com/tidymodels/parsnip/issues/892.

The commits are (mostly) working through the package model/engine combination by model/engine combination, but the aggregated pattern is

hfrick commented 1 year ago

@simonpcouch The changes are pretty boring to read - the more challenging aspect is if I overlooked anything to add. If you could tilt your review toward that, that'd be great! :raised_hands:

hfrick commented 1 year ago

Thank you! The .time vectors are indeed false positives. I plan on changing those when I make up my mind between calling them observed times or event times. The other ones were very helpful, thanks!

hfrick commented 1 year ago

CI failures are due to changes in the new pillar, so unrelated to this PR

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.