`survival_prob_orsf()` should take a parnip model

tidymodels / censored

Parsnip wrappers for survival models

https://censored.tidymodels.org/

Other

123 stars 12 forks source link

`survival_prob_orsf()` should take a parnip model #283

Closed hfrick closed 10 months ago

hfrick commented 11 months ago

The other survival_prob_*() functions all take an object of class model_fit while survival_prob_orsf() takes an object that's the engine fit, i.e., of class "orsf". For consistency, this should also be a parsnip model.

hfrick commented 10 months ago

I had my glmnet googles on when I opened that issue: the functions for coxnet models are the only ones that take a parsnip model fit rather than an engine fit. Nonetheless, that's an inconsistency. Closing this issue in favor of #295 for a holistic view of the problem.

github-actions[bot] commented 9 months ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.