search

tidymodels / censored

Parsnip wrappers for survival models
https://censored.tidymodels.org/
Other
123 stars 12 forks source link

update tests for `aorsf` version 0.1.2 #287

Closed bcjaeger closed 10 months ago

bcjaeger commented 11 months ago

Hello!

I am planning to release aorsf version 0.1.2 soon, and this update will provide support for both classification and regression oblique random forests. Internally, I've re-worked some of the attributes and class types of aorsf, which means the new version will break some of the tests in test-rand_forest_aorsf.R. I've prepared a pull request with minor changes to this file that will make it compatible with 0.1.2. Would it be okay if I submitted this PR for you to review?

I'd be happy to add some additional code in this PR to resolve #283 if you'd like! Just let me know.

edit: my mistake, version 0.1.2

EmilHvitfeldt commented 11 months ago

Hello @bcjaeger 👋

Thanks for the heads up! The PR is highly welcomed! We are all out-of-office between Christmas and new years, but we will look at it once we are back!

bcjaeger commented 11 months ago

Excellent, thank you! I appreciate the reply and hope you are having a lovely time away.

hfrick commented 10 months ago

closed in #288

github-actions[bot] commented 10 months ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.