search

tidymodels / censored

Parsnip wrappers for survival models
https://censored.tidymodels.org/
Other
123 stars 12 forks source link

remove print._coxnet() #313

Closed EmilHvitfeldt closed 7 months ago

EmilHvitfeldt commented 7 months ago

I'm not able easily find the origin of this function. but as it stands it appears to have been a near copy of the old print.model_fit().

The other errors appears to be related to https://github.com/tidymodels/parsnip/issues/1109

simonpcouch commented 7 months ago

It does seem like some "The training data has been saved for prediction." lines are being removed in snaps. Unless this is blocking you on a parsnip PR, I'll defer to @hfrick on reviewing this one, as she's more likely to understand how important it is that we call that out.

hfrick commented 7 months ago

That line is the reason for this print method to exist :) Could you update it rather than remove it?

EmilHvitfeldt commented 7 months ago

I used NextMethod() to make it so print.model_fit() is in charge of the actually printing, and print._coxnet() only adds extra.

hfrick commented 7 months ago

Excellent, thank you! 🙌 I've taken that idea just a smidge further, leaning into the parnsip method for everything but that one extra sentence.

github-actions[bot] commented 6 months ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.