tidymodels / dials

Tools for creating tuning parameter values
https://dials.tidymodels.org/
Other
113 stars 27 forks source link

Remove the `param_grid` subclass #117

Closed DavisVaughan closed 4 years ago

DavisVaughan commented 4 years ago

This PR removes the param_grid tbl subclass altogether, as it is not used anywhere and there are no know S3 methods that dispatch off of it. This simplifies things greatly, since we don't have to maintain vctrs/dplyr compat for it.

It also has a few tweaks to the existing parameters vctrs/dplyr compat as I continue to iron out ways for it to be more generic (but they are very minor)

github-actions[bot] commented 3 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.