grid_* will make duplicate rows when size exceeds the maximum number of unique combinations

tidymodels / dials

Tools for creating tuning parameter values

https://dials.tidymodels.org/

Other

111 stars 26 forks source link

grid_* will make duplicate rows when size exceeds the maximum number of unique combinations #133

Closed yogat3ch closed 4 years ago

yogat3ch commented 4 years ago

Hi folks, I noticed that grid_* functions will make duplicate rows of combinations when size is specified, without warning. Perhaps it should default to the maximum size necessary if the size exceeds that necessary to run all of the possible combinations and give the user a message?

Here's a reprex:

.g <- dials::grid_latin_hypercube(
    x = dials::parameters(
        list(prod_degree = dials::prod_degree(),
        prune_method = dials::prune_method())
    ), 
    size = 100
)
sum(duplicated(.g))

juliasilge commented 4 years ago

Related to tidymodels/tune#259

github-actions[bot] commented 3 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.